Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does a contents sheet actually need to be supplied by the user? #75

Closed
matt-dray opened this issue Jul 5, 2022 · 3 comments
Closed
Labels
could MoSCoW priority ('on ice') discuss Point for discussion enhancement New feature or request

Comments

@matt-dray
Copy link
Collaborator

Currently the user must add a sheet with sheet_type of "contents". Why? Surely this can be entirely auto-generated; there's nothing extra a user should put in this sheet that isn't already provided (i.e. tab_title and sheet_title).

@matt-dray matt-dray added enhancement New feature or request discuss Point for discussion code labels Jul 5, 2022
@matt-dray
Copy link
Collaborator Author

Perhaps because the user may want to add additional information to the table beyond just the tab and sheet titles.

For example, see the Labour Market Overview demo spreadsheet in the best practice guidance, which says:

Note: In this spreadsheet the table of contents includes a column for: publication date, next publication date and source.

This is needed for this spreadsheet as the dates for the next publication date vary and the sources are not all the same.

If all your tables will get updated on the same date and they are all from the same source you can put this information on the cover sheet, you do not need to add these columns to the table of contents.

@matt-dray matt-dray added the could MoSCoW priority ('on ice') label Jul 6, 2022
@matt-dray
Copy link
Collaborator Author

matt-dray commented Nov 15, 2023

Also it's conceptually easier when using create_a11ytable() to see that you're supplying a number of objects that matches the number of sheets in the output, right? Might seem odd to have one fewer than the user might expect to provide.

@matt-dray
Copy link
Collaborator Author

This is a duplicate of #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could MoSCoW priority ('on ice') discuss Point for discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant