Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add motor_output_limit to GUI #1722

Closed
2 tasks
spuder opened this issue Oct 6, 2019 · 10 comments
Closed
2 tasks

Add motor_output_limit to GUI #1722

spuder opened this issue Oct 6, 2019 · 10 comments

Comments

@spuder
Copy link
Contributor

spuder commented Oct 6, 2019

Feature request: Add ability to set motor_output_limit in the gui.

Joshua Bardwell - Throttle/Motor scaling https://www.youtube.com/watch?v=u2LMGDS7DFI

Questions:

  • Is this already available as a variable? or will it require a MSP change?
  • Where should this be configured?

Screenshot 2019-10-06 19 19 53

Related issues/MR

betaflight/betaflight#7482
betaflight/betaflight#5608

@McGiverGim
Copy link
Member

I doubt that it must go in the PID Profile Settings. Maybe in the Rateprofile Settings is a better place, when we configure others things related with Throttle. But if it is a motor limit and not a throttle limit, maybe in the motors configuration is a good place too (but it will not be attached to any profile).

@mikeller
Copy link
Member

mikeller commented Oct 7, 2019

@McGiverGim: It is actually a PID Profile setting in the firmware. So it should go onto the PID tuning tab, and if it does not go into the PID profile subtab it will need at least a note stating that it is PID profile dependent.

@Docteh
Copy link
Contributor

Docteh commented Oct 7, 2019

I think auto_profile_cell_count goes together with motor_output_limit, so I think it makes sense to add them both at the same time.

the rate profile has throttle limit, so I think motor limit on pid tab makes more sense.

@mikeller
Copy link
Member

mikeller commented Oct 8, 2019

@Docteh: Yeah, the assignment of parameters to PID- and rateprofiles can be seen as 'organic' (at best). We should probably take a green field approach and define what should go where from scratch.

@Juzzle1
Copy link
Contributor

Juzzle1 commented Mar 3, 2020

I think this is possibly more than a cosmetic issue

It's not obvious to users that the 'copy profile settings' button in the configurator overwrites the CLI-set auto_profile_cell_count and motor_output_limit on the destination profile.

While this makes sense as these settings are stored as part of the individual PID profiles, it could make it easy to smoke a motor, for example by copying a 4s profile to a 6s profile which was previously set to scale the motor outputs.

Maybe a warning to this effect would be a good idea when copying profiles if new GUI options aren't going to make it in the next release?

@asizon
Copy link
Member

asizon commented Mar 3, 2020

This feature is already added to configurator for 10.7.0
#1901

@bolts1111
Copy link

I'm planning to have two quads running everything the same including motor size 2306. The difference being in motor kv one at 2450kv and the other at 2750kv. i'm then planning to run 6s and run the same rpm on each. Would the scaling work differently and feel different? Also how different is it running a true 6s / unscaled back motor?

@asizon
Copy link
Member

asizon commented Apr 26, 2020

Can be closed by #1901

@mikeller
Copy link
Member

Keeping this open for now - resizing of the camera frame is still something that could / should be done at some point.

@asizon
Copy link
Member

asizon commented Jul 4, 2021

Closed by #1901
@mikeller your resizing comment goes in #1833

@asizon asizon closed this as completed Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants