-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add motor_output_limit to GUI #1722
Comments
I doubt that it must go in the PID Profile Settings. Maybe in the Rateprofile Settings is a better place, when we configure others things related with Throttle. But if it is a motor limit and not a throttle limit, maybe in the motors configuration is a good place too (but it will not be attached to any profile). |
@McGiverGim: It is actually a PID Profile setting in the firmware. So it should go onto the PID tuning tab, and if it does not go into the PID profile subtab it will need at least a note stating that it is PID profile dependent. |
I think the rate profile has throttle limit, so I think motor limit on pid tab makes more sense. |
@Docteh: Yeah, the assignment of parameters to PID- and rateprofiles can be seen as 'organic' (at best). We should probably take a green field approach and define what should go where from scratch. |
I think this is possibly more than a cosmetic issue It's not obvious to users that the 'copy profile settings' button in the configurator overwrites the CLI-set While this makes sense as these settings are stored as part of the individual PID profiles, it could make it easy to smoke a motor, for example by copying a 4s profile to a 6s profile which was previously set to scale the motor outputs. Maybe a warning to this effect would be a good idea when copying profiles if new GUI options aren't going to make it in the next release? |
This feature is already added to configurator for 10.7.0 |
I'm planning to have two quads running everything the same including motor size 2306. The difference being in motor kv one at 2450kv and the other at 2750kv. i'm then planning to run 6s and run the same rpm on each. Would the scaling work differently and feel different? Also how different is it running a true 6s / unscaled back motor? |
Can be closed by #1901 |
Keeping this open for now - resizing of the camera frame is still something that could / should be done at some point. |
Feature request: Add ability to set
motor_output_limit
in the gui.Joshua Bardwell - Throttle/Motor scaling https://www.youtube.com/watch?v=u2LMGDS7DFI
Questions:
Related issues/MR
betaflight/betaflight#7482
betaflight/betaflight#5608
The text was updated successfully, but these errors were encountered: