Show GPS home position found in FC

[HThuren]

Show GPS home position found i FC at GPS tab

Some design change to keep room to the GPS map

Depends on betaflight/betaflight#12899

[haslinghuis]

@HThuren just type #12899 in the commit field when flashing for testing the firmware PR.

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> FAIL
• Tested label found -> FAIL
• assigned to an approver -> FAIL
• approver count at least three -> FAIL

[haslinghuis]

Forgot to add: Please update preview as you do :)

[HThuren]

Here we go, now live data from flash with #12899

[haslinghuis]

As suspected this shows the same location what is the use case for this change?

Maybe when using waypoints https://www.youtube.com/watch?v=htdJly1_lGU

[HThuren]

As suspected this shows the same location what is the use case for this change?

Maybe when using waypoints https://www.youtube.com/watch?v=htdJly1_lGU

Nice video .-), the test was to check if there came something form the FC.
Move ½m away, battery on, activate from radio, deactivate, USB connect and see some values not the same, as when moved ½m back. I don't think your suspection holds :)

Use case: to check if home position are set, fx when use notepad on field

[McGiverGim]

I don't see too much utility for this, but mabye someone uses it sometime...

For the other side, I think is better to put the "Home Latitude / Longitude:" row just before or after the current gps coords, renaming it to "Current Latitude / Longitude:" to let the difference clear.

[HThuren]

I don't see too much utility for this, but mabye someone uses it sometime...

For the other side, I think is better to put the "Home Latitude / Longitude:" row just before or after the current gps coords, renaming it to "Current Latitude / Longitude:" to let the difference clear.

Good point, I do some redesign
Like this ?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[HThuren]

@haslinghuis @ctzsnooze I still see this as a improvement (but have been away for job), at least for debugging purpose.
Only add few instructions to firmware, but the can show the actual setting in configurator.
Another solution are to add the information to cli output but that will increase firmware more.
Please reconsider.

There also are some changes to GUI at gps.js, but of course the can be made in another PR

[haslinghuis]

Depends on betaflight/betaflight#12899

This could be totally done using configurator. Once gps fix has been attained record the gps lat lon value as home position.

But as the GPS is acquiring new data - updating position - maybe showing some deviation. Only RTK will have correction data.

[HThuren]

good input from @ctzsnooze related to changes (now unwanted) in firmware :
The problem is that we are short on MSP space, so we need a really coherent reason for adding this. I'm still unclear about what the true user benefit would be. We know that home will be set to the latitude and longitude values present on arming. We can see those values on the screen in configurator at arm time.

We could make a function in Configurator alone that showed the Home values just by looking to see if someone armed, had a 3D fix, and had enough sats, and saving those values at arm time.

Perhaps better again, we could have a button that saved the GPS values at any time. We could consider those values to be 'home' value if saved when we had a 3D fix and our 8 sats, or we could save at any time just to see how stable the subsequent position estimates would be if we had saved 'home' at this time.

We could also compute the distance from the 'saved' position to the current latitude and longitude, which would help a user understand the magnitude of the drift, in simple distance terms, had 'home' been set at the time we pressed the button.

So I think there are Configurator only possibilities to provide very useful information about recent latitude and longtitude without using MSP.

[haslinghuis]

Also would like to have a status for the gps fix status change (signal loss occurrences - maybe with a optional sound when changing state).

[haslinghuis]

Closing as firmware [PR] is closed.

[HThuren]

Closing as firmware [PR] is closed.

I kept this open, since ctzsnooze had som good issues for future development, where do we keep them, when this PR are closed ?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[HThuren]

@haslinghuis thank you :-)

[haslinghuis]

No worries - was not aware it was still in development.