Add SPA06 and SPL07 baro support for Kakute series FC #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sugaarK We are hoping to add these default support for the Holybro Kakute series. |
sugaarK
approved these changes
Nov 7, 2024
ot0tot
reviewed
Nov 7, 2024
Comment on lines
35
to
+37
| #define USE_BARO | ||
| #define USE_BARO_BMP280 | ||
| #define USE_BARO_DPS310 |
There was a problem hiding this comment.
Suggested change
| #define USE_BARO | |
| #define USE_BARO_BMP280 | |
| #define USE_BARO_DPS310 |
This FC has no I2C resources assigned, so these defines should not be included.
ot0tot
reviewed
Nov 7, 2024
Comment on lines
35
to
+36
| #define USE_BARO_BMP280 | ||
| #define USE_BARO_DPS310 |
There was a problem hiding this comment.
Suggested change
| #define USE_BARO_BMP280 | |
| #define USE_BARO_DPS310 | |
| #define USE_BARO | |
| #define USE_BARO_BMP280 | |
| #define USE_BARO_DPS310 |
Also remove these lines further down
#define USE_BARO
#define DEFAULT_BARO_DEVICE BARO_BMP280
ot0tot
reviewed
Nov 7, 2024
Comment on lines
33
to
+34
| #define USE_BARO_BMP280 | ||
| #define USE_BARO_DPS310 |
There was a problem hiding this comment.
Same comment as KAKUTEF7 target
Suggested change
| #define USE_BARO_BMP280 | |
| #define USE_BARO_DPS310 | |
| #define USE_BARO | |
| #define USE_BARO_BMP280 | |
| #define USE_BARO_DPS310 |
and remove
#define USE_BARO
#define DEFAULT_BARO_DEVICE BARO_BMP280
There was a problem hiding this comment.
Also remove DEFAULT_BARO defines in other targets.
no worries |
|
Continue in #609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BARO used in the KAKUTE series flight controllers is BMP280. BMP280 is now discontinued. Need to replace the baro of KAKUTE series flight controllers with SPA06/SPL07.