From 5f2b1741d5b4c88a87c0cc55ae16aa4d18f00e89 Mon Sep 17 00:00:00 2001 From: pskl Date: Thu, 10 Oct 2024 17:13:05 +0200 Subject: [PATCH] Change abroad type to principal (the ADMIN type is apparently not supported) --- app/services/asp/mappers/adresse_mapper.rb | 2 +- lib/asp/entities/adresse.rb | 2 +- spec/lib/asp/entities/adresse_spec.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/services/asp/mappers/adresse_mapper.rb b/app/services/asp/mappers/adresse_mapper.rb index 60c71f090..d96fae1e5 100644 --- a/app/services/asp/mappers/adresse_mapper.rb +++ b/app/services/asp/mappers/adresse_mapper.rb @@ -4,7 +4,7 @@ module ASP module Mappers class AdresseMapper PRINCIPAL_ADDRESS_TYPE = "PRINCIPALE" - ABROAD_ADDRESS_TYPE = "ADMIN" # From ASP Doc + ABROAD_ADDRESS_TYPE = "ADMIN" # From ASP Doc (Apparently not supported by ASP!) MAPPING = { codecominsee: :address_city_insee_code, diff --git a/lib/asp/entities/adresse.rb b/lib/asp/entities/adresse.rb index ada142c0e..9f3aebc3b 100644 --- a/lib/asp/entities/adresse.rb +++ b/lib/asp/entities/adresse.rb @@ -48,7 +48,7 @@ def self.from_payment_request(payment_request) # rubocop:disable Metrics/AbcSize raise ASP::Errors::MissingEstablishmentPostalCodeError if establishment.postal_code.blank? new( - codetypeadr: Mappers::AdresseMapper::ABROAD_ADDRESS_TYPE, + codetypeadr: Mappers::AdresseMapper::PRINCIPAL_ADDRESS_TYPE, codecominsee: establishment.commune_code, codepostalcedex: establishment.postal_code, codeinseepays: InseeCodes::FRANCE_INSEE_COUNTRY_CODE diff --git a/spec/lib/asp/entities/adresse_spec.rb b/spec/lib/asp/entities/adresse_spec.rb index daf5402c8..75092017d 100644 --- a/spec/lib/asp/entities/adresse_spec.rb +++ b/spec/lib/asp/entities/adresse_spec.rb @@ -37,7 +37,7 @@ it "creates an Adresse instance with establishment details" do # rubocop:disable RSpec/ExampleLength adresse = described_class.from_payment_request(request) expect(adresse).to have_attributes( - codetypeadr: ASP::Mappers::AdresseMapper::ABROAD_ADDRESS_TYPE, + codetypeadr: ASP::Mappers::AdresseMapper::PRINCIPAL_ADDRESS_TYPE, codecominsee: establishment.commune_code, codepostalcedex: establishment.postal_code, codeinseepays: InseeCodes::FRANCE_INSEE_COUNTRY_CODE