Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Case Weights To Threshold Splits #21

Open
mhermher opened this issue Aug 12, 2020 · 0 comments
Open

Use Case Weights To Threshold Splits #21

mhermher opened this issue Aug 12, 2020 · 0 comments

Comments

@mhermher
Copy link

If the weights passed into the model are case weights, then should they not be used to determine whether a split should happen or not?

In partition.c me->num_obs is being compared to rp.min_split instead of me->sum_wt.

similarly, in anova.c (haven't looked at the others), right_n and left_n are being compared to edge (rp.min_node) instead of right_wt and left_wt.

Using case weights to represent number of cases is really helpful in managing runtime and memory efficiency, but the split logic in the C code is not considering them.

Even writing as custom split function would solve the latter case, but not the former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant