Fix touch gestures not working on MAUI iOS once packaged #1704
Conversation
Release candidate 4
Update master
Update web site samples to master
Update master to rc 4.5
|
Thanks for the PR! I will review and merge this asap! |
|
Hey @beto-rodriguez, I see you rebased the PR and a few conflicts appeared. Are you gonna fix the conflicts with dev brach or should I do it? |
|
@albyrock87 I changed the base to dev, I'll try to fix conflicts with the dev branch |
|
@beto-rodriguez do you have any news on this one? Now that NET9 automatically disconnects MAUI handlers when leaving the page we get a crash which this PR would prevent and also handle the disconnection properly.
|
|
@albyrock87 I've been working on #1705, that should be almost ready, it is an important change in the library that will improve drastically the flexibility of the library to create custom drawn elements. I should be able to review this in the next days. |
|
Thanks again again for the PR! I tested on all platforms, and it works! |
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "8.0.401", | |||
There was a problem hiding this comment.
Is there a particular reason to use this version?
Maybe upgrading the version to 9.x is a good idea, just want to confirm, if there is a particular reason, I can make this commit.
There was a problem hiding this comment.
I recently asked Microsoft what we should use as library authors regarding broad compatibility.
I think that for now you can stick with 8.0.100 with roll forward latest feature, but make sure you target net8.0-ios17.0 in the TargetFramework and not just net8.0-ios because that implicitly targets only the latest native version released with the latest workload (right now is 18.2).
This ensures compatibility with MAUI8 and MAUI9.
Take into consideration that many developers (like me) are still on .NET8 considering that MAUI9 is still a bit "unstable", or simply because they didn't have enough time to upgrade.
|
|
||
| using LiveChartsCore.SkiaSharpView.Maui; | ||
|
|
||
| namespace Microsoft.Maui.Hosting; |
There was a problem hiding this comment.
Also here, can I change the namespace to LiveChartsCore.SkiaSharpView.Maui?
is there a particular reason for using that ns?
There was a problem hiding this comment.
The reason I've used this namespace is for dev-experience.
In MauiProgram.cs you already have this namespace imported, so the intellisense will automatically suggest the extension method.
This is a common pattern used by Microsoft.Extensions.* packages.
If you don't like it, do what you want: it's not a big deal :)
There was a problem hiding this comment.
Thanks @albyrock87, I will consider both comments!
Fixes #1684
Directory.Build.propsto propagate properties to all projectMauiVersionbecause it was one of the issue, but I suggest to bring here alsoAuthorand other common properties (LangVersion?)..global.jsonfile in order to use the proper .NET + workloads when debugging and packingChartBehaviourto avoid taking a (now) useless reference to the virtual view.UseLiveCharts()in MAUI program<DebugType>embedded</DebugType>as it makes impossible to place breakpoints while debuggingI don't have a windows machine so I cannot try/verify I haven't broke anything there.
Please merge this as soon as possible because we're stuck due to #1684.
If you have questions I'm also available on Discord (same username).
Thanks