Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace react-native-modal with react-native-modalfy #382

Open
guytepper opened this issue Oct 12, 2024 · 10 comments
Open

Replace react-native-modal with react-native-modalfy #382

guytepper opened this issue Oct 12, 2024 · 10 comments
Labels
good first issue Easy tasks for new contributors up for grabs Help wanted: Claim this issue!

Comments

@guytepper
Copy link
Member

Since react-native-modal isn't maintained anymore, we get warnings on Android related to it's reanimated usage.

Let's replace it with react-native-modalfy, which is a maintained library, and offers better performance and features.

@guytepper guytepper added up for grabs Help wanted: Claim this issue! good first issue Easy tasks for new contributors labels Oct 12, 2024
@Vivek1235
Copy link

I would like to work on this issue?

@guytepper
Copy link
Member Author

@Vivek1235 thank you! It's yours :)

Let's do it incrementally - start with migrating the date-picker-modal.android.tsx file to the new library.
After that we can proceed to the other 2 occurrences: route-list-warning.tsx and tip-thanks-modal.tsx.

@guytepper
Copy link
Member Author

@Vivek1235 just heads up, the branch version/2.3.3 is the branch you should base your work on. main might have build issues.

If you have any questions/issues don't hesitate to reach out! 🙏

@Vivek1235
Copy link

I am not able to run the project on my system

@guytepper
Copy link
Member Author

@Vivek1235 what issue do you encounter? Please provide more details so we can help :)

@Vivek1235
Copy link

Screenshot 2024-10-14 173525
I am getting this error when i try to run on ios simulator

@guytepper
Copy link
Member Author

@Vivek1235 It's not possible to run the iOS simulator on a Windows machine. Try running Android instead, you can follow the instructions here:
https://reactnative.dev/docs/set-up-your-environment?os=windows&platform=android

@guytepper
Copy link
Member Author

@Vivek1235 are you still up to working on it? Totally okay if not :) But we want to get this done soon.

@Vivek1235
Copy link

I tried working on that but unfortunately am not able to run the project on my system. Apologies for the late notice.

@guytepper
Copy link
Member Author

No worries, thanks for giving it a try 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easy tasks for new contributors up for grabs Help wanted: Claim this issue!
Projects
None yet
Development

No branches or pull requests

2 participants