Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] Navigating to frontend route directly gives 404 #165

Open
glencbz opened this issue Apr 2, 2023 · 0 comments
Open

[staging] Navigating to frontend route directly gives 404 #165

glencbz opened this issue Apr 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@glencbz
Copy link
Collaborator

glencbz commented Apr 2, 2023

Steps to reproduce:

This happens because our current urlmap resolves the paths directly to files on GCS e.g. /support-detail resolves to the nonexistent /support-detail file on GCS. To fix this, we need to redirect these other paths to /index.html.

We need to be careful though, because there are a bunch of other paths that we do want to resolve to GCS files:

image

The best approach would probably be to allowlist just the paths we care about (it should just be the ones here), and route everything else to /index.html by default. That would also give us a chance to do 404 handling if the user decides to navigate to /does-not-exist.

@glencbz glencbz added the bug Something isn't working label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant