Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode does not work properly #18

Open
ThePyProgrammer opened this issue Nov 3, 2021 · 3 comments
Open

Dark Mode does not work properly #18

ThePyProgrammer opened this issue Nov 3, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ThePyProgrammer
Copy link
Collaborator

The Dark Mode, which is currently using Vuetify's Dark Mode functionality, does not load properly in our current application. This is due to the fact that Vuetify does not convert custom defined colors, like #FFFFFF to #000000, which would be a problem since this means that boards described as white are actually still white under the dark mode.

These are multiple ways to solve this issue, as shown below:

Manually Adjust Vuetify and the Code to Accept Dark Mode

(see the branch dark-mode for info)
This is the tedious route, wherein, Vuetify is used, under the Android-style Material UI Color Scheme Definition. This may not be the most ideal solution, but on pull request is trying to implement that.

Use the Dark-Reader Extension

When we showed the application to Sid, the Dark Reader Chrome Extension had in fact ran its magic and completely beautified the user interface, which is something Vuetify was unable to do. To achieve similar results, we simply need to use the Dark Reader NPM Package, and possibly it's Vue-specific counterpart.

@ThePyProgrammer ThePyProgrammer added bug Something isn't working good first issue Good for newcomers labels Nov 3, 2021
@ThePyProgrammer
Copy link
Collaborator Author

Actually, this repo is particularly for people in the Saylah Development Team. I apologise, we didn't mean to make this open source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants
@ThePyProgrammer and others