Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: setup-shell when no configuration should prompt which shell to use #271

Open
balupton opened this issue Jan 7, 2025 · 2 comments
Open

Suggestion: setup-shell when no configuration should prompt which shell to use #271

balupton opened this issue Jan 7, 2025 · 2 comments
Assignees
@balupton
Labels
enhancement Improvement or suggestion
Milestone
Share Launch [v3]

Comments

@balupton
Copy link
Member

balupton commented Jan 7, 2025

For some reason, setup-shell doesn't prompt the user which shell to use when there isn't configuration, it just selects the first one:
https://github.com/bevry/dorothy/blob/master/commands/setup-shell

Just needs to use choose. Perhaps choose didn't exist when setup-shell was written.
@balupton balupton added the enhancement Improvement or suggestion label Jan 7, 2025
@balupton
Copy link
Member Author

balupton commented Jan 7, 2025

/cc @b9Joker108

@balupton balupton added this to the Share Launch [v3] milestone Jan 13, 2025
@balupton balupton self-assigned this Jan 29, 2025
@balupton
Copy link
Member Author

balupton commented Feb 6, 2025

This is solved locally.

@balupton balupton mentioned this issue Feb 6, 2025
Draft
@balupton balupton changed the title Suggestion: setup-shell when no configuration should prompt which shell to use Suggestion: setup-shell when no configuration should prompt which shell to use Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balupton balupton

Labels
enhancement Improvement or suggestion
Milestone
Share Launch [v3]
Development

No branches or pull requests
1 participant
@balupton