Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize pr-downloader to not re-download map if it's present. #51

Open
p2004a opened this issue Mar 31, 2023 · 0 comments
Open

Optimize pr-downloader to not re-download map if it's present. #51

p2004a opened this issue Mar 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@p2004a
Copy link
Collaborator

p2004a commented Mar 31, 2023 •
edited
Loading

This is a regression from some refactoring a bunch of time ago, and is a safe behavior to just redownload, but it can be optimized to not have to do it.

The implementation would be computing of map file hash on disk, and comparing with the one available in hosting.

Comparing just file presence is not enough, as client could ask to redownload because there is some corruption and existing file on disk is not recognized correctly as valid map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p2004a