Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doctrine/dbal 4 upwards #114

Closed
wants to merge 1 commit into from

Conversation

bambamboole
Copy link

@bambamboole bambamboole commented Aug 22, 2024

wThis PR allows doctrine/dbal:^4.0 as dependency, which makes it installable and executable with PHP 8.3 and Laravel 11.

Fixes #112

Nevertheless, I still have a red test suite:

composer test
> vendor/bin/phpunit
PHPUnit 9.6.20 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.10
Configuration: /Users/bambamboole/Projects/forks/laravel-er-diagram-generator/phpunit.xml.dist
Warning:       No code coverage driver available

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 17:
  - Element 'filter': This element is not expected.

  Test results may not be as expected.


...I
In ConnectsToDatabase.php line 22:
                                                                                                                                                                                                   
  Declaration of Illuminate\Database\PDO\Concerns\ConnectsToDatabase::connect(array $params, $username = null, $password = null, array $driverOptions = []) must be compatible with Doctrine\DBAL  
  \Driver::connect(array $params): Doctrine\DBAL\Driver\Connection                                                                                                                                 
                                                                                                                                                                                                   


In ConnectsToDatabase.php line 22:
                                                                                                                                                                                                   
  Declaration of Illuminate\Database\PDO\Concerns\ConnectsToDatabase::connect(array $params, $username = null, $password = null, array $driverOptions = []) must be compatible with Doctrine\DBAL  
  \Driver::connect(array $params): Doctrine\DBAL\Driver\Connection                                                                                                                                 
                                                                                                                                                                                                   


In ConnectsToDatabase.php line 22:
                                                                                                                                                                                                   
  Declaration of Illuminate\Database\PDO\Concerns\ConnectsToDatabase::connect(array $params, $username = null, $password = null, array $driverOptions = []) must be compatible with Doctrine\DBAL  
  \Driver::connect(array $params): Doctrine\DBAL\Driver\Connection                                                                                                                                 
                                                                                                                                                                                                   


In ConnectsToDatabase.php line 22:
                                                                                                                                                                                                   
  Declaration of Illuminate\Database\PDO\Concerns\ConnectsToDatabase::connect(array $params, $username = null, $password = null, array $driverOptions = []) must be compatible with Doctrine\DBAL  
  \Driver::connect(array $params): Doctrine\DBAL\Driver\Connection                                                                                                                                 
                                                                                                                                                                                                   


In ConnectsToDatabase.php line 22:
                                                                                                                                                                                                   
  Declaration of Illuminate\Database\PDO\Concerns\ConnectsToDatabase::connect(array $params, $username = null, $password = null, array $driverOptions = []) must be compatible with Doctrine\DBAL  
  \Driver::connect(array $params): Doctrine\DBAL\Driver\Connection                                                                                                                                 
                                                                                                                                                                                                   


Fatal error: Declaration of Illuminate\Database\PDO\Concerns\ConnectsToDatabase::connect(array $params, $username = null, $password = null, array $driverOptions = []) must be compatible with Doctrine\DBAL\Driver::connect(array $params): Doctrine\DBAL\Driver\Connection in /Users/bambamboole/Projects/forks/laravel-er-diagram-generator/vendor/laravel/framework/src/Illuminate/Database/PDO/Concerns/ConnectsToDatabase.php on line 22
Script vendor/bin/phpunit handling the test event returned with error code 255

@mechelon
Copy link
Member

mechelon commented Oct 4, 2024

Laravel 11 has removed doctrine as dependency, so it's probably because of your project explicitly requiring dbal.
However, I'm open for this change - do the tests pass with your adjustment, as well as the package commands?

@bambamboole
Copy link
Author

Let me check this the weekend. I actually pivoted to mermaid and made a small package around this, so maybe we can also do here something driver based .

@mechelon
Copy link
Member

mechelon commented Dec 6, 2024

Duplicate of #116

@mechelon mechelon marked this as a duplicate of #116 Dec 6, 2024
@mechelon mechelon closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.X and Laravel 11 suport
2 participants