Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to async-script-loader is not up to date with latest API #15

Open
FunMiles opened this issue Dec 27, 2020 · 1 comment
Open

Call to async-script-loader is not up to date with latest API #15

FunMiles opened this issue Dec 27, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@FunMiles
Copy link

async-script-loader expects urls to be an array. The GoogleAuth code makes the call with a single URL. This is easy to fix.

loader( [ {type: 'script',
        url: '//apis.google.com/js/api:client.js'} ],
        () => window['gapi'],
        () => initialise()
      )
@antony
Copy link
Member

antony commented Nov 1, 2021

Happy to accept a PR if you have time.

@antony antony added the help wanted Extra attention is needed label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants