-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI clients code generation - Kiota #87
Comments
cc. @tombentley please assign this issue to me. |
@andreaTP it's an AP you want, right? (not an ADR) |
Hi @tombentley , thanks for taking a look! I'm finding it a little confusing to identify if I should submit an AP or an ADR. Currently in the available documentation: https://github.com/bf2fc6cc711aee1a0c2a/architecture/blob/main/pages/about/index.adoc#architectural-pattern I can see that, in the |
ADR records a decision (specific to a single service) that MUST be followed in applicable circumstances. The only way to avoid it is to supersede the decision. PADR records a decision (applying to all services) that MUST be followed in applicable circumstances. The only way to avoid it is to supersede the decision. Obviously these are a bit written-in-stone. So AP provides mechanism for saying "We think this is what we want to do, but we want to see whether the pattern is really generally applicable before we promote it to PADR". From the draft document you linked, I think this should be an AP. Once we've got experience with Kiota for at least one service we could have an PADR to record that it's what everyone MUST use from now on. Does that sound OK/work for you? |
Thanks a ton for the clarification. Yes, I'm fine with submitting it as an AP! |
create ap |
/create ap |
Closing following creation of AP-17 |
@tombentley the number given by the automation is colliding on @shawkins #82 |
Sigh. Avoiding this kind of thing is why the automation allocates the id in an initial (basically empty) PR. It's not the fault of @shawkins for not knowing that (because the bot is only now working thanks to @grdryn). @andreaTP I'll bump your AP id manually. That should be enough to fix it for future APs too. |
@andreaTP you now have ADR 18 (you can re-fetch |
Cool, thanks for sorting things out! I'll continue to work on |
The `repo.getHomepage()` returns the website configured in the repository details, so you can see the link behind the .adoc file path in bf2fc6cc711aee1a0c2a/architecture#87 (comment) points to that site rather than to the corresponding file page on GitHub. It seems like `repo.getHtmlUrl()` is the best choice.
Reference the Original doc.
The text was updated successfully, but these errors were encountered: