Skip to content

Latest commit

 

History

History
84 lines (57 loc) · 3.55 KB

CONTRIBUTING.adoc

File metadata and controls

84 lines (57 loc) · 3.55 KB

Contributing guide

Want to contribute? Great!
We try to make it easy, and all contributions, even the smaller ones, are more than welcome. This includes bug reports, fixes, documentation, examples…​ But first, read this page (including the small print at the end).

All original contributions to kas-broker-plugins are licensed under the ASL - Apache License, version 2.0 or later; or, if another license is specified as governing the file or directory being modified, such other license.

All contributions are subject to the Developer Certificate of Origin (DCO). The DCO text is also included verbatim in the dco.txt file in the root directory of the repository.

2. Reporting an issue

This project primarily uses MGDSTRM project in Red Hat’s Jira for issue tracking, but you can alternatively open an issue here in GitHub directly.

If you believe you found a bug, please indicate a way to reproduce it, what you are seeing, and what you would expect to see.

3. Before you contribute

To contribute, use GitHub Pull Requests, from your own fork.

Also, make sure you have set up your Git authorship correctly:

git config --global user.name "Your Full Name"
git config --global user.email [email protected]

If you use different computers to contribute, please make sure the name is the same on all your computers.

We use this information to acknowledge your contributions in release announcements.

3.1. Code reviews

All submissions, including submissions by project members, need to be reviewed by at least two kas-broker-plugins committers before being merged.

GitHub Pull Request Review Process is followed for every pull request.

3.2. Coding Guidelines

  • We decided to disallow @author tags in the Javadoc: they are difficult to maintain

  • Commits should be atomic and semantic. Please properly squash your pull requests before submitting them. Fixup commits can be used temporarily during the review process but things should be squashed at the end to have meaningful commits. We use merge commits so the GitHub Merge button cannot do that for us. If you don’t know how to do that, just ask in your pull request, we will be happy to help!

3.3. Continuous Integration

kas-broker-plugins CI is based on GitHub Actions, which means that everyone has the ability to automatically execute CI in their forks as part of the process of making changes. We ask that all non-trivial changes go through this process, so that the contributor gets immediate feedback, while at the same time keeping our CI fast and healthy for everyone.

3.4. Tests and documentation are not optional

Don’t forget to include tests in your pull requests. Also don’t forget the documentation (reference documentation, javadoc…​).

4. The small print

This project is an open source project, please act responsibly, be nice, polite and enjoy!