Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efp.matrix: implement lrvar and vcov parameters #32

Open
GreatEmerald opened this issue Mar 12, 2021 · 2 comments
Open

efp.matrix: implement lrvar and vcov parameters #32

GreatEmerald opened this issue Mar 12, 2021 · 2 comments
Assignees

Comments

@GreatEmerald
Copy link
Contributor

@appelmar Could you check this part? Achim implemented two optional parameters to efp[.formula], could this be ported to the matrix function as well? Or maybe we should merge the two functions so that changes like that are easier to integrate?

Originally posted by @GreatEmerald in #29 (comment)

@appelmar
Copy link
Member

AFAICS, integrating lrvar would be straightforward for types "Rec-CUSUM", "OLS-CUSUM", "Rec-MOSUM", and "OLS-MOSUM" but more difficult for RE and ME. Integrating vcov seems even more complex as it is a function which would need to be called from the C++ code (since it is only used for types RE and ME). Shall I try to add lrvar? Maybe we can still add both arguments but throw a warning if it is not implemented?

@GreatEmerald
Copy link
Contributor Author

Yes, I think the way to go is that if it is too complex, we can follow upstream, which is to say ignore it with a warning. Handling it in some way is useful, as otherwise users might be confused as to why it's not working for them when using matrices, but works when using the formula method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants