Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The inclusion of dir="ltr" or dir="rtl" leads to problems in the Moodle core multilang filter. #10

Open
lucaboesch opened this issue Feb 27, 2024 · 1 comment

Comments

@lucaboesch
Copy link
Contributor

lucaboesch commented Feb 27, 2024

See https://tracker.moodle.org/browse/MDL-81055

To reproduce, add the lines

            'dir ltr case EN' => [
                'English',
                '<span lang="en" class="multilang" dir="ltr">English</span><span lang="fr" class="multilang" dir="ltr">Français</span>',
                'en',
            ],

to filter/multilang/tests/filter_test.php (line 125) and run that PHPUnit test.

@srobotta
Copy link
Collaborator

For the moment I have removed the dir attribute in master. However, as you noted correctly, this should be fixed in the filter itself. I also believe that when we published the plugin, these attributes where working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants