-
Notifications
You must be signed in to change notification settings - Fork 25
/
V013.go
126 lines (98 loc) · 2.64 KB
/
V013.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
package V013
import (
"go/ast"
"go/token"
"go/types"
"github.com/bflad/tfproviderlint/helper/terraformtype/helper/schema"
"github.com/bflad/tfproviderlint/passes/commentignore"
"github.com/bflad/tfproviderlint/passes/helper/schema/schemavalidatefuncinfo"
"golang.org/x/tools/go/analysis"
)
const Doc = `check for custom SchemaValidateFunc that implement validation.StringInSlice() or validation.StringNotInSlice()
The V013 analyzer reports when custom SchemaValidateFunc declarations can be
replaced with validation.StringInSlice() or validation.StringNotInSlice().`
const analyzerName = "V013"
var Analyzer = &analysis.Analyzer{
Name: analyzerName,
Doc: Doc,
Requires: []*analysis.Analyzer{
commentignore.Analyzer,
schemavalidatefuncinfo.Analyzer,
},
Run: run,
}
func run(pass *analysis.Pass) (interface{}, error) {
ignorer := pass.ResultOf[commentignore.Analyzer].(*commentignore.Ignorer)
schemaValidateFuncs := pass.ResultOf[schemavalidatefuncinfo.Analyzer].([]*schema.SchemaValidateFuncInfo)
for _, schemaValidateFunc := range schemaValidateFuncs {
if ignorer.ShouldIgnore(analyzerName, schemaValidateFunc.Node) {
continue
}
if !hasIfStringEquality(schemaValidateFunc.Body, pass.TypesInfo) {
continue
}
pass.Reportf(schemaValidateFunc.Pos, "%s: custom SchemaValidateFunc should be replaced with validation.StringInSlice() or validation.StringNotInSlice()", analyzerName)
}
return nil, nil
}
func hasIfStringEquality(node ast.Node, info *types.Info) bool {
result := false
ast.Inspect(node, func(n ast.Node) bool {
switch n := n.(type) {
default:
return true
case *ast.IfStmt:
if !hasStringEquality(n, info) {
return true
}
result = true
return false
}
})
return result
}
func hasStringEquality(node ast.Node, info *types.Info) bool {
result := false
ast.Inspect(node, func(n ast.Node) bool {
binaryExpr, ok := n.(*ast.BinaryExpr)
if !ok {
return true
}
if !exprIsString(binaryExpr.X, info) || !exprIsString(binaryExpr.Y, info) {
return true
}
if !tokenIsEquality(binaryExpr.Op) {
return true
}
result = true
return false
})
return result
}
func exprIsString(e ast.Expr, info *types.Info) bool {
switch e := e.(type) {
default:
return false
case *ast.BasicLit:
return e.Kind == token.STRING
case *ast.Ident:
switch t := info.TypeOf(e).Underlying().(type) {
default:
return false
case *types.Basic:
return t.Kind() == types.String
}
}
}
func tokenIsEquality(t token.Token) bool {
validTokens := []token.Token{
token.EQL, // ==
token.NEQ, // !=
}
for _, validToken := range validTokens {
if t == validToken {
return true
}
}
return false
}