Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormDateTimeInput component listens for all click events even when the time selector is hdden #20

Open
bhch opened this issue Feb 9, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@bhch
Copy link
Owner

bhch commented Feb 9, 2022

Once the FormDateTimeInput component mounts, it starts listening for all click events. This is to close the time selector popup when a user clicks outside. But this also listens for click events even when the time selector is hidden. This seems bad for performance.

The component should only listen for click events while the time selector is visible/mounted. The solution is to move the click event listening code down to the time selector popup.

@bhch bhch added the bug Something isn't working label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant