-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTML output #56
Comments
This would fix the self-closing div/iframe issues if I'm not mistaken? |
Hi Alex, Could you explain the "self-closing div/iframe issues"? I'm not aware of them, and I don't think we have any tests for problems around divs or iframes, so if you have any examples I can make sure to fix that. |
If the input says Ideally, an HTML5-aware serializer would be smarter about this (knowing that only "void" elements can have self-closing tags).
|
inline-html = '<div></div>
<iframe src="http://www.google.com"></iframe>'
=> "<div></div>\n<iframe src=\"http://www.google.com\"></iframe>"
Maruku.new(inline-html).to_html
=> "<div /><iframe src='http://www.google.com' />" I believe self closing div's and several other elements are valid XHTML but not HTML and this causes issues in the browsers I've used. Adding empty space between the elements (i.e. |
OK, in that case yes, when HTML output is added, it should support this (by virtue of Nokogiri doing the right thing). |
+1. The current Maruku (REXML, really) also chokes on html attributes without values. <span data-myattribute>I cause an `malformed XML: missing tag start` REXML error</span> |
Right now Maruku only produces XHTML output, but it should be able to produce HTML output instead.
The text was updated successfully, but these errors were encountered: