Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The function evaluate is overloaded! #8

Open
erlebach opened this issue Apr 7, 2022 · 1 comment
Open

The function evaluate is overloaded! #8

erlebach opened this issue Apr 7, 2022 · 1 comment

Comments

@erlebach
Copy link

erlebach commented Apr 7, 2022

Hi,
In evaluation.py, you define the function evaluate twice with different arguments. And yet, Python does not support function overloading. Here are your declarations:

def evaluate(G: object, k: int = 2, method: str = 'all'):

def evaluate(G, dfnodes, graphEdges, method, k):

I do not understand how your examples could work. Any help is appreciated.

Also, could you please provide an uncommented example that calls predict and evaluate that can run as is? At this
time, you include an example in the README.md file, but it does not run properly.

Thanks,

Gordon
@soran-ghaderi
Copy link
Member

Hi Gordon,

The second function is deprecated, however, we will update the package soon.

Could you please provide more information on what kind of issue you encounter when you run the examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants