Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition between transition and interaction causes broken rendering #530

Open
Prinzhorn opened this issue Sep 9, 2024 · 0 comments
Labels

Comments

@Prinzhorn
Copy link

Prinzhorn commented Sep 9, 2024

Thanks for making this library, it was very easy to integrate. However, I immediately ran into the following bug:

Describe the bug

When you hit the "right arrow key" to navigate to the next image while the first image is still in the opening transition, everything falls apart.

Are you able to reproduce the bug in the demo site

Yes

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://biati-digital.github.io/glightbox/
  2. Click on the first image
  3. Instantly "right arrow key" while the image is opening (it is tricky to always repro, see video)

Expected behavior

Either the keyboard navigation is ignored or it transitions to the second image

Screenshots

Screencast.from.2024-09-09.10-37-16.webm

Desktop:

Latest Firefox and Chromium on Ubuntu. I don't think this is a browser bug.

@gingerchew gingerchew added the bug label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants