From df7a89f8051d822c123474834a507e1016780a7e Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 15 Jan 2025 21:53:16 -0500 Subject: [PATCH 1/2] Ignore www.incf.org link check.. unlikely to go away (hopefully) Currently check fails URL `https://www.incf.org/' Name `INCF' Parent URL file:///home/circleci/project/site/introduction.html, line 1795, col 2 Real URL https://www.incf.org/ Check time 0.084 seconds Result Error: SSLError: HTTPSConnectionPool(host='www.incf.org', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certifica... possibly due to outdated collection of root certificates in the env where testing? dunno, but we better address it since it brings overall CI to red quite often, causing fatigue and increasing likeliness to skip important issues. --- .circleci/config.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 63f1dd4ce8..6be476ce5c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -60,6 +60,7 @@ jobs: --ignore-url 'https://github.com/[^/]*' \ --ignore-url 'https://doi.org/.*' \ --ignore-url 'https://bids-specification.readthedocs.io/en/stable/.*' \ + --ignore-url 'https://www.incf.org' \ ~/project/site/*html ~/project/site/*/*.html else echo "Release PR - do nothing" From 619f48b4c9748e85257e06a2b7e3e5ebe7ba3f6f Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 15 Jan 2025 21:57:55 -0500 Subject: [PATCH 2/2] Sort URLs in ignore-url options for linkchecker Would be easier to find one, and to add one without thinking much where etc --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 6be476ce5c..53dac2879d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -55,11 +55,11 @@ jobs: # failures for local file:/// -- yoh found no better way, linkchecker -t 1 --check-extern \ --ignore-url 'file:///.*' \ + --ignore-url 'https://bids-specification.readthedocs.io/en/stable/.*' \ + --ignore-url 'https://doi.org/.*' \ --ignore-url 'https://fonts.gstatic.com' \ - --ignore-url 'https://github.com/bids-standard/bids-specification/(pull|tree)/.*' \ --ignore-url 'https://github.com/[^/]*' \ - --ignore-url 'https://doi.org/.*' \ - --ignore-url 'https://bids-specification.readthedocs.io/en/stable/.*' \ + --ignore-url 'https://github.com/bids-standard/bids-specification/(pull|tree)/.*' \ --ignore-url 'https://www.incf.org' \ ~/project/site/*html ~/project/site/*/*.html else