-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for comments on an implementation of BEP 16 #1909
Comments
they look good to me!
…On Tue, Aug 27, 2024 at 9:18 AM Matt Cieslak ***@***.***> wrote:
@tsalo <https://github.com/tsalo> and I have been working on getting the
derivatives of our dMRI post-processing workflows into BEP16 compliance.
We'd appreciate some thoughts and comments on the file names we're
producing. Personally, I think the entities and suffixes in BEP16 are
intuitive and am pretty happy with how these look.
Here
<https://github.com/PennLINC/qsirecon/blob/main/qsirecon/tests/data/scalar_mapper_outputs.txt>
is a list of the outputs from a workflow that fits GQI and Tensor models in
DSI Studio and DKI models from DIPY. It warps the scalar maps from these
outputs into MNI2009cAsym space. (any thoughts @frankyeh
<https://github.com/frankyeh>, @arokem <https://github.com/arokem>?)
And here
<https://github.com/PennLINC/qsirecon/blob/main/qsirecon/tests/data/tortoise_recon_outputs.txt>
are the files written out by a tensor+MAPMRI fit done in TORTOISE. (any
thoughts @eurotomania <https://github.com/eurotomania>?).
There are a few other files in this directory that list the expected
outputs from our workflows, but they also list file formats that are not
included in BEP16, such as the fib, mapping and the AMICO config pickle
file. All the files have documentation
<https://qsirecon.readthedocs.io/en/latest/builtin_workflows.html> but
only those listed under *Scalar Maps* might be included in BEP 16.
Thanks in advance!
—
Reply to this email directly, view it on GitHub
<#1909>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACDI4PIWY7B7AK2F5CMWTDZTR4BDAVCNFSM6AAAAABNGD5CCKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4DSMZUGM3DGMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Also pinging @Lestropie, @francopestilli, @oesteban and @PeerHerholz in case they have comments about this implementation of BEP16 in software proposed by @mattcieslak and colleagues. |
This should instead be:
(same for the other output space) The key insights here---which may feel initially unintuitive but I'm increasingly convinced is the right way to do it---are that:
For pipeline derivatives, it is (I believe) RECOMMENDED in BIDS that any hyphen in the directory name separate the name of the pipeline from the "version" of that pipeline. However I believe that "version" should be eg. a software version number a la Semantic Versioning, not "I ran the pipeline in two different ways and here are the two different outputs". Don't think it's enforced, and you may have just named things in this way for the sake of presenting this example here, but it nevertheless jumps out at me. The "software used" that necessitates "versioning" here, mostly in metadata but optionally in the directory name also, is ultimately
|
Hi everyone, thanks so much for this @mattcieslak and @tsalo, it already looks amazing. Concerning the specific details of outputs and naming, I would refer to @Lestropie's points which IMHO reflect the latest discussions and implementation of A while ago, we also started working on a little tool to test the proposal, it's a Best, Peer |
@tsalo and I have been working on getting the derivatives of our dMRI post-processing workflows into BEP16 compliance. We'd appreciate some thoughts and comments on the file names we're producing. Personally, I think the entities and suffixes in BEP16 are intuitive and am pretty happy with how these look.
Here is a list of the outputs from a workflow that fits GQI and Tensor models in DSI Studio and DKI models from DIPY. It warps the scalar maps from these outputs into MNI2009cAsym space. (any thoughts @frankyeh, @arokem?)
And here are the files written out by a tensor+MAPMRI fit done in TORTOISE. (any thoughts @eurotomania?).
There are a few other files in this directory that list the expected outputs from our workflows, but they also list file formats that are not included in BEP16, such as the fib, mapping and the AMICO config pickle file. All the files have documentation but only those listed under Scalar Maps might be included in BEP 16.
Thanks in advance!
The text was updated successfully, but these errors were encountered: