Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The required metadata in qMRI fieldmaps not incorporated into schema #2018

Open
nbeliy opened this issue Dec 19, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@nbeliy
Copy link

nbeliy commented Dec 19, 2024

Describe your problem in detail.

Dear BIDS community,

Recently we discovered that the required metadata for qMRI field maps is absent in schema (at least in v1.10.0).

A quick grep on rules shows that RepetitionTime is defined as metadata only for asl, func and mrs.

> grep -rnI RepetitionTime rules/sidecars/
rules/sidecars/asl.yaml:14:    RepetitionTimePreparation: required
rules/sidecars/func.yaml:23:MRIFuncRepetitionTime:
rules/sidecars/func.yaml:30:    RepetitionTime:
rules/sidecars/func.yaml:38:    - '!("RepetitionTime" in sidecar)'
rules/sidecars/func.yaml:43:      level_addendum: mutually exclusive with `RepetitionTime`
rules/sidecars/anat.yaml:16:    RepetitionTimeExcitation: optional
rules/sidecars/anat.yaml:17:    RepetitionTimePreparation: optional
rules/sidecars/mrs.yaml:96:MRSRepetitionTime:
rules/sidecars/mrs.yaml:102:    RepetitionTime:
rules/sidecars/mrs.yaml:110:    - '!("RepetitionTime" in sidecar)'
rules/sidecars/mrs.yaml:114:      level_addendum: mutually exclusive with `RepetitionTime`

Moreover, no metadata rules seems to be defined for TB1AFI suffix:

grep -rnI TB1AFI rules/sidecars/

Describe what you expected.

No response

BIDS specification section

https://bids-specification.readthedocs.io/en/v1.8.0/appendices/qmri.html#field-maps

@nbeliy nbeliy added the bug Something isn't working label Dec 19, 2024
@effigies
Copy link
Collaborator

Looks like a typo. RepetitionTime for TB1AFI should be RepetitionTimeExcitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants