Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It works! Some feedback and kudos #9

Open
1 of 7 tasks
yarikoptic opened this issue Jan 10, 2018 · 0 comments
Open
1 of 7 tasks

It works! Some feedback and kudos #9

yarikoptic opened this issue Jan 10, 2018 · 0 comments

Comments

@yarikoptic
Copy link
Collaborator

yarikoptic commented Jan 10, 2018

Just a "feedback" item to state that I have tried on a sample dataset we generated here and it worked nicely!

Some notes from our quick experience which might lead to tunes up at some point (by me or anyone else) to make bids2nda even better ;)

  • Thanks @chrisfilo ! The tool is a great help!
  • output directory had to be created manually or it fails to create output file. may be should be pre-created if not exists
  • we were preparing to "upload" using their web app. Since that one is not sharing "current working directory" with the bids2nda, we had to specify full paths (for input/output directories) so that web app could find the files.
    • if there is a cmdline client for that, it would be cool if bids2nda could invoke it and point to the files to be uploaded, and then relative paths could be used (probably). I would have preferred to upload using relative paths since IIRC those do get recorded in NDA DB
    • issue a warning if relative path to dataset/output is provided describing that most likely upload via web app would fail due to different working path
  • in our heudiconv'erted dataset we have __dup-01 files which are the canceled runs. We had to remove them before running bids2nda since it was picking them up as well and (IIRC) getting confused or something. I wonder if there could be an option or .bidsignore support to ignore such files.
  • introduce checks for the upload of any .tsv or .json file if it has TODO in them. Our use case is upload of heudiconv produced dataset. We provide templates for all the needed files, including _events.tsv files. Since those are uploaded as well, ideally they should be populated before the upload. Such a check with a warning issued would help to avoid uploading "too raw to share" datasets ;)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant