Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motion: adding SpatialAxes etc to JSON schema #1838

Closed
sappelhoff opened this issue Nov 3, 2023 · 0 comments · Fixed by #1839
Closed

motion: adding SpatialAxes etc to JSON schema #1838

sappelhoff opened this issue Nov 3, 2023 · 0 comments · Fixed by #1839

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Nov 3, 2023

MOTION allows for this:

{
  "reference_frame": {
    "Levels": {
      "global": {
        "SpatialAxes": "ALS",
        "RotationOrder": "ZXY",
        "RotationRule": "right-hand"
      },
      "local": {
        "Description": "Joint angles are described following [...]"
      }
    }
  }
}

(source)

Would we have to add:

  • SpatialAxes
  • RotationOrder
  • RotationRule

to the general data_dictionary.json JSON schema (Description and TermURL are permitted via this PR)? Because this general data_dictionary.json would be called upon for a potential channels.json file in a dataset, right? (because we don't have a specific channels.json schema)

Is there something in the BIDS schema we should adjust for this?

So far in the BIDS spec, we have a markdown table for the above metadata: https://github.com/bids-standard/bids-specification/blob/47d912de10634f3baa9bbf36aff1f8a1d06597c2/src/modality-specific-files/motion.md?plain=1#L211-L216

And the rows in that table have individual entries in the schema, for example: https://github.com/bids-standard/bids-specification/blob/47d912de10634f3baa9bbf36aff1f8a1d06597c2/src/schema/objects/metadata.yaml#L2725-L2736

... but I see no schemafied "rules" how in a channels.json you can have something like in the JSON example above.

Originally posted by @sappelhoff in https://github.com/bids-standard/bids-validator/issues/1837#issuecomment-1792159597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant