Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node and npm versions to package.json and .node-version file #104

Open
PaulREnglish opened this issue Sep 13, 2024 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@PaulREnglish
Copy link

PaulREnglish commented Sep 13, 2024

What problem does this address?

Currently, it is unclear which versions of npm and node the developer should use should they wish to contribute.

What is your proposed solution?

My solution has 2 parts:

  1. Add the version of npm and node to the "engines" property in package.json. Use the build tools as an example.
  2. Add a .node-version file so certain node version managers can automatically use the correct version of node.
@PaulREnglish PaulREnglish added the enhancement New feature or request label Sep 13, 2024
@g-elwell
Copy link
Member

Please can we use a .node-version file if implementing this instead of .nvmrc

@PaulREnglish
Copy link
Author

Please can we use a .node-version file if implementing this instead of .nvmrc

Amended the OP.

@PaulREnglish PaulREnglish changed the title Add node and npm versions to package.json and .nvmrc file Add node and npm versions to package.json and .node-version file Oct 4, 2024
@PaulREnglish
Copy link
Author

PR: #116

@PaulREnglish PaulREnglish self-assigned this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants