Merge pull request #3010 from bigcommerce/PAYPAL-5348

feat(payment): PAYPAL-5348 remove paypal 3ds experiment

Author: bc-yaroslav-zhmutskyi

packages/bigcommerce-payments-integration/src/bigcommerce-payments-credit-cards/bigcommerce-payments-credit-cards-payment-strategy.spec.ts

@@ -25,7 +25,6 @@ import {
 import {
     getBillingAddress,
     getCart,
-    getConfig,
     PaymentIntegrationServiceMock,
 } from '@bigcommerce/checkout-sdk/payment-integrations-test-utils';
 
@@ -479,18 +478,6 @@ describe('BigCommercePaymentsCreditCardsPaymentStrategy', () => {
         });
 
         it('does not submit order and payment if 3ds failed', async () => {
-            jest.spyOn(
-                paymentIntegrationService.getState(),
-                'getStoreConfigOrThrow',
-            ).mockReturnValue({
-                ...getConfig().storeConfig,
-                checkoutSettings: {
-                    ...getConfig().storeConfig.checkoutSettings,
-                    features: {
-                        'PAYPAL-4591.paypal_commerce_3ds_verification': true,
-                    },
-                },
-            });
             jest.spyOn(paypalSdk, 'CardFields').mockImplementation(
                 (options: BigCommercePaymentsCardFieldsConfig) => {
                     eventEmitter.on('onApprove', () => {

packages/bigcommerce-payments-integration/src/bigcommerce-payments-credit-cards/bigcommerce-payments-credit-cards-payment-strategy.ts

@@ -227,8 +227,6 @@ export default class BigCommercePaymentsCreditCardsPaymentStrategy implements Pa
 
         const paypalSdk = this.bigCommercePaymentsIntegrationService.getPayPalSdkOrThrow();
         const executeCallback = this.getExecuteCallback(fields);
-        const state = this.paymentIntegrationService.getState();
-        const features = state.getStoreConfigOrThrow().checkoutSettings.features;
 
         const cardFieldsConfig: BigCommercePaymentsCardFieldsConfig = {
             style: this.getInputStyles(styles),
@@ -238,9 +236,8 @@ export default class BigCommercePaymentsCreditCardsPaymentStrategy implements Pa
                 liabilityShift,
             }: BigCommercePaymentsCardFieldsOnApproveData) => {
                 if (
-                    features?.['PAYPAL-4591.paypal_commerce_3ds_verification'] &&
-                    (liabilityShift === LiabilityShiftEnum.No ||
-                        liabilityShift === LiabilityShiftEnum.Unknown)
+                    liabilityShift === LiabilityShiftEnum.No ||
+                    liabilityShift === LiabilityShiftEnum.Unknown
                 ) {
                     throw new Error();
                 }

packages/paypal-commerce-integration/src/paypal-commerce-credit-card/paypal-commerce-credit-cards-payment-strategy.spec.ts

@@ -17,7 +17,6 @@ import {
 import {
     getBillingAddress,
     getCart,
-    getConfig,
     PaymentIntegrationServiceMock,
 } from '@bigcommerce/checkout-sdk/payment-integrations-test-utils';
 import {
@@ -470,18 +469,6 @@ describe('PayPalCommerceCreditCardsPaymentStrategy', () => {
         });
 
         it('does not submit order and payment if 3ds failed', async () => {
-            jest.spyOn(
-                paymentIntegrationService.getState(),
-                'getStoreConfigOrThrow',
-            ).mockReturnValue({
-                ...getConfig().storeConfig,
-                checkoutSettings: {
-                    ...getConfig().storeConfig.checkoutSettings,
-                    features: {
-                        'PAYPAL-4591.paypal_commerce_3ds_verification': true,
-                    },
-                },
-            });
             jest.spyOn(paypalSdk, 'CardFields').mockImplementation(
                 (options: PayPalCommerceCardFieldsConfig) => {
                     eventEmitter.on('onApprove', () => {

packages/paypal-commerce-integration/src/paypal-commerce-credit-card/paypal-commerce-credit-cards-payment-strategy.ts

@@ -220,8 +220,6 @@ export default class PayPalCommerceCreditCardsPaymentStrategy implements Payment
 
         const paypalSdk = this.paypalCommerceIntegrationService.getPayPalSdkOrThrow();
         const executeCallback = this.getExecuteCallback(fields);
-        const state = this.paymentIntegrationService.getState();
-        const features = state.getStoreConfigOrThrow().checkoutSettings.features;
 
         const cardFieldsConfig: PayPalCommerceCardFieldsConfig = {
             style: this.getInputStyles(styles),
@@ -231,9 +229,8 @@ export default class PayPalCommerceCreditCardsPaymentStrategy implements Payment
                 liabilityShift,
             }: PayPalCommerceCardFieldsOnApproveData) => {
                 if (
-                    features?.['PAYPAL-4591.paypal_commerce_3ds_verification'] &&
-                    (liabilityShift === LiabilityShiftEnum.No ||
-                        liabilityShift === LiabilityShiftEnum.Unknown)
+                    liabilityShift === LiabilityShiftEnum.No ||
+                    liabilityShift === LiabilityShiftEnum.Unknown
                 ) {
                     throw new Error();
                 }