Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement gene search functionality and gene information page (#11) #14

Merged

Conversation

gromdimon
Copy link
Contributor

@gromdimon gromdimon commented Aug 22, 2023

Issue: #11

Tasks:

  • Implement home page with search bar
  • Implement Gene Details Page
  • Write tests

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 84.97% and project coverage change: -12.61% ⚠️

Comparison is base (c3884a4) 100.00% compared to head (0bf2b48) 87.39%.

Additional details and impacted files
@@             Coverage Diff              @@
##              main      #14       +/-   ##
============================================
- Coverage   100.00%   87.39%   -12.61%     
============================================
  Files            3       14       +11     
  Lines           41      230      +189     
  Branches         0       41       +41     
============================================
+ Hits            41      201      +160     
- Misses           0       28       +28     
- Partials         0        1        +1     
Flag Coverage Δ
backend 100.00% <100.00%> (ø)
frontend 84.81% <84.73%> (-15.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
frontend/src/router/index.ts 50.00% <33.33%> (ø)
frontend/src/views/GeneDetailView.vue 73.78% <73.78%> (ø)
backend/app/main.py 100.00% <100.00%> (ø)
frontend/src/api/annonars.ts 100.00% <100.00%> (ø)
frontend/src/api/common.ts 100.00% <100.00%> (ø)
frontend/src/api/utils.ts 100.00% <100.00%> (ø)
frontend/src/components/HeaderDefault.vue 100.00% <100.00%> (ø)
frontend/src/components/HeaderDetailPage.vue 100.00% <100.00%> (ø)
frontend/src/components/SearchBar.vue 100.00% <100.00%> (ø)
frontend/src/stores/geneInfo.ts 100.00% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

backend/app/main.py Outdated Show resolved Hide resolved
backend/app/main.py Outdated Show resolved Hide resolved
frontend/package.json Outdated Show resolved Hide resolved
frontend/src/api/annonars.ts Outdated Show resolved Hide resolved
frontend/src/assets/main.css Outdated Show resolved Hide resolved
frontend/src/views/HomeView.vue Outdated Show resolved Hide resolved
frontend/tsconfig.app.json Outdated Show resolved Hide resolved
info?hgnc-id=HGNC:1100 Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
frontend/src/views/GeneDetailView.vue Outdated Show resolved Hide resolved
@gromdimon gromdimon marked this pull request as ready for review August 28, 2023 13:54
@gromdimon gromdimon requested a review from holtgrewe August 28, 2023 16:02
@gromdimon
Copy link
Contributor Author

Some notes:

  • We ommit tests in docker builds : see .dockerignore
  • AnnonarsClient does not properly handles exceptions
  • SearchBar selection for genomeRelease is not tested
  • HomeView performSearch is not tested
  • GeneDetailView navigation bar redirections with # in url is not tested

@gromdimon gromdimon enabled auto-merge (squash) August 30, 2023 11:18
@gromdimon gromdimon dismissed holtgrewe’s stale review August 30, 2023 11:22

already discussed

@gromdimon gromdimon merged commit 644a2d4 into main Aug 30, 2023
8 of 10 checks passed
@gromdimon gromdimon deleted the 11-implement-gene-search-functionality-and-gene-information-page branch August 30, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants