Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search works only from second time (#23, #24) #30

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

gromdimon
Copy link
Contributor

Issues:

#23
#24

This was linked to issues Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.70% ⚠️

Comparison is base (655e549) 85.77% compared to head (6d6c69e) 84.07%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   85.77%   84.07%   -1.70%     
==========================================
  Files          14       16       +2     
  Lines         239      270      +31     
  Branches       43       45       +2     
==========================================
+ Hits          205      227      +22     
- Misses         32       41       +9     
  Partials        2        2              
Flag Coverage Δ
backend 87.27% <ø> (-10.41%) ⬇️
frontend 83.25% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
frontend/src/components/HeaderDetailPage.vue 100.00% <ø> (ø)
frontend/src/router/index.ts 50.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gromdimon gromdimon requested a review from holtgrewe September 1, 2023 10:59
Copy link
Member

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holtgrewe holtgrewe merged commit 4ca6249 into main Sep 1, 2023
9 of 10 checks passed
@holtgrewe holtgrewe deleted the 23-search-bar-only-works-the-second-time branch September 1, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep links do not work Search bar only works the second time
2 participants