Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide irods_backend to taskflowbackend iRODS tasks in __init__() #1814

Closed
mikkonie opened this issue Oct 12, 2023 · 1 comment
Closed

Provide irods_backend to taskflowbackend iRODS tasks in __init__() #1814

mikkonie opened this issue Oct 12, 2023 · 1 comment
Assignees
@mikkonie
Labels
app: taskflowbackend Issue in the taskflowbackend app internal Changes invisible to the user or APIs (e.g. refactoring and optimization) wontfix This will not be worked on
Milestone
v0.14.1

Comments

@mikkonie
Copy link
Contributor

This eliminates the need to provide it in execute() and revert() kwargs and make things easier for #1592. Also it makes sense because we would not be even creating iRODS tasks if the backend wasn't available.
@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) app: taskflowbackend Issue in the taskflowbackend app labels Oct 12, 2023
@mikkonie mikkonie added this to the v0.14.1 milestone Oct 12, 2023
@mikkonie mikkonie self-assigned this Oct 12, 2023
@mikkonie mikkonie added the wontfix This will not be worked on label Oct 12, 2023
@mikkonie
Copy link
Contributor Author

I tried this in practice and realized it's not in fact a great idea, as the backend only gets used by very few tasks, at least for now. Better to keep it as an inject arg and provide to helper method when it's called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: taskflowbackend Issue in the taskflowbackend app internal Changes invisible to the user or APIs (e.g. refactoring and optimization) wontfix This will not be worked on
Projects
None yet
Milestone
v0.14.1
Development

No branches or pull requests
1 participant
@mikkonie