diff --git a/velox/connectors/hive/HiveConnector.cpp b/velox/connectors/hive/HiveConnector.cpp index f34a5442f0b5..5617b8613d1e 100644 --- a/velox/connectors/hive/HiveConnector.cpp +++ b/velox/connectors/hive/HiveConnector.cpp @@ -24,27 +24,15 @@ #include "velox/dwio/dwrf/RegisterDwrfReader.h" #include "velox/dwio/dwrf/RegisterDwrfWriter.h" -// Meta's buck build system needs this check. -#ifdef VELOX_ENABLE_GCS +#include "velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.h" // @manual #include "velox/connectors/hive/storage_adapters/gcs/RegisterGCSFileSystem.h" // @manual -#endif -#ifdef VELOX_ENABLE_HDFS3 #include "velox/connectors/hive/storage_adapters/hdfs/RegisterHdfsFileSystem.h" // @manual -#endif -#ifdef VELOX_ENABLE_S3 #include "velox/connectors/hive/storage_adapters/s3fs/RegisterS3FileSystem.h" // @manual -#endif -#ifdef VELOX_ENABLE_ABFS -#include "velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.h" // @manual -#endif #include "velox/dwio/dwrf/reader/DwrfReader.h" #include "velox/dwio/dwrf/writer/Writer.h" #include "velox/dwio/orc/reader/OrcReader.h" -// Meta's buck build system needs this check. -#ifdef VELOX_ENABLE_PARQUET #include "velox/dwio/parquet/RegisterParquetReader.h" // @manual #include "velox/dwio/parquet/RegisterParquetWriter.h" // @manual -#endif #include "velox/expression/FieldReference.h" #include @@ -138,24 +126,14 @@ void HiveConnectorFactory::initialize() { dwrf::registerDwrfReaderFactory(); dwrf::registerDwrfWriterFactory(); orc::registerOrcReaderFactory(); -// Meta's buck build system needs this check. -#ifdef VELOX_ENABLE_PARQUET + parquet::registerParquetReaderFactory(); parquet::registerParquetWriterFactory(); -#endif -// Meta's buck build system needs this check. -#ifdef VELOX_ENABLE_S3 + filesystems::registerS3FileSystem(); -#endif -#ifdef VELOX_ENABLE_HDFS3 filesystems::registerHdfsFileSystem(); -#endif -#ifdef VELOX_ENABLE_GCS filesystems::registerGCSFileSystem(); -#endif -#ifdef VELOX_ENABLE_ABFS filesystems::abfs::registerAbfsFileSystem(); -#endif return true; }(); } diff --git a/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp b/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp index e2a638df613d..5a566770f4c2 100644 --- a/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp +++ b/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp @@ -15,8 +15,8 @@ */ #ifdef VELOX_ENABLE_ABFS -#include "velox/connectors/hive/storage_adapters/abfs/AbfsFileSystem.h" -#include "velox/connectors/hive/storage_adapters/abfs/AbfsUtil.h" +#include "velox/connectors/hive/storage_adapters/abfs/AbfsFileSystem.h" // @manual +#include "velox/connectors/hive/storage_adapters/abfs/AbfsUtil.h" // @manual #include "velox/core/Config.h" #endif diff --git a/velox/connectors/hive/storage_adapters/gcs/RegisterGCSFileSystem.cpp b/velox/connectors/hive/storage_adapters/gcs/RegisterGCSFileSystem.cpp index 4c76478dfca2..7be24fa1b523 100644 --- a/velox/connectors/hive/storage_adapters/gcs/RegisterGCSFileSystem.cpp +++ b/velox/connectors/hive/storage_adapters/gcs/RegisterGCSFileSystem.cpp @@ -15,8 +15,8 @@ */ #ifdef VELOX_ENABLE_GCS -#include "velox/connectors/hive/storage_adapters/gcs/GCSFileSystem.h" -#include "velox/connectors/hive/storage_adapters/gcs/GCSUtil.h" +#include "velox/connectors/hive/storage_adapters/gcs/GCSFileSystem.h" // @manual +#include "velox/connectors/hive/storage_adapters/gcs/GCSUtil.h" // @manual #include "velox/core/Config.h" #endif diff --git a/velox/connectors/hive/storage_adapters/hdfs/RegisterHdfsFileSystem.cpp b/velox/connectors/hive/storage_adapters/hdfs/RegisterHdfsFileSystem.cpp index 47734838838f..d1db8bc864e2 100644 --- a/velox/connectors/hive/storage_adapters/hdfs/RegisterHdfsFileSystem.cpp +++ b/velox/connectors/hive/storage_adapters/hdfs/RegisterHdfsFileSystem.cpp @@ -17,8 +17,8 @@ #ifdef VELOX_ENABLE_HDFS3 #include "folly/concurrency/ConcurrentHashMap.h" -#include "velox/connectors/hive/storage_adapters/hdfs/HdfsFileSystem.h" -#include "velox/connectors/hive/storage_adapters/hdfs/HdfsUtil.h" +#include "velox/connectors/hive/storage_adapters/hdfs/HdfsFileSystem.h" // @manual +#include "velox/connectors/hive/storage_adapters/hdfs/HdfsUtil.h" // @manual #include "velox/core/Config.h" #include "velox/dwio/common/FileSink.h" #endif diff --git a/velox/connectors/hive/storage_adapters/s3fs/RegisterS3FileSystem.cpp b/velox/connectors/hive/storage_adapters/s3fs/RegisterS3FileSystem.cpp index abc62991456e..885fa2439f19 100644 --- a/velox/connectors/hive/storage_adapters/s3fs/RegisterS3FileSystem.cpp +++ b/velox/connectors/hive/storage_adapters/s3fs/RegisterS3FileSystem.cpp @@ -15,13 +15,13 @@ */ #ifdef VELOX_ENABLE_S3 -#include "velox/connectors/hive/HiveConfig.h" -#include "velox/connectors/hive/storage_adapters/s3fs/S3FileSystem.h" -#include "velox/connectors/hive/storage_adapters/s3fs/S3Util.h" +#include "velox/connectors/hive/HiveConfig.h" // @manual +#include "velox/connectors/hive/storage_adapters/s3fs/S3FileSystem.h" // @manual +#include "velox/connectors/hive/storage_adapters/s3fs/S3Util.h" // @manual #include "velox/dwio/common/FileSink.h" #endif -#include "velox/connectors/hive/storage_adapters/s3fs/RegisterS3FileSystem.h" +#include "velox/connectors/hive/storage_adapters/s3fs/RegisterS3FileSystem.h" // @manual namespace facebook::velox::filesystems { diff --git a/velox/dwio/parquet/RegisterParquetReader.cpp b/velox/dwio/parquet/RegisterParquetReader.cpp index 995b3acd2a5f..2f4cc94b81fe 100644 --- a/velox/dwio/parquet/RegisterParquetReader.cpp +++ b/velox/dwio/parquet/RegisterParquetReader.cpp @@ -15,7 +15,7 @@ */ #ifdef VELOX_ENABLE_PARQUET -#include "velox/dwio/parquet/reader/ParquetReader.h" +#include "velox/dwio/parquet/reader/ParquetReader.h" // @manual #endif namespace facebook::velox::parquet { diff --git a/velox/dwio/parquet/RegisterParquetWriter.cpp b/velox/dwio/parquet/RegisterParquetWriter.cpp index b6a9ccee465c..1d6c0e033357 100644 --- a/velox/dwio/parquet/RegisterParquetWriter.cpp +++ b/velox/dwio/parquet/RegisterParquetWriter.cpp @@ -15,7 +15,7 @@ */ #ifdef VELOX_ENABLE_PARQUET -#include "velox/dwio/parquet/writer/Writer.h" +#include "velox/dwio/parquet/writer/Writer.h" // @manual #endif namespace facebook::velox::parquet { diff --git a/velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp b/velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp index 49c7136376f8..80d076e3a39a 100644 --- a/velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp +++ b/velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp @@ -17,17 +17,17 @@ #include #include "velox/common/base/tests/GTestUtils.h" -#include "velox/dwio/common/tests/utils/DataFiles.h" -#include "velox/dwio/parquet/RegisterParquetReader.h" -#include "velox/dwio/parquet/reader/PageReader.h" -#include "velox/dwio/parquet/reader/ParquetReader.h" +#include "velox/dwio/common/tests/utils/DataFiles.h" // @manual +#include "velox/dwio/parquet/RegisterParquetReader.h" // @manual +#include "velox/dwio/parquet/reader/PageReader.h" // @manual +#include "velox/dwio/parquet/reader/ParquetReader.h" // @manual=//velox/connectors/hive:velox_hive_connector_parquet #include "velox/exec/tests/utils/AssertQueryBuilder.h" -#include "velox/exec/tests/utils/HiveConnectorTestBase.h" +#include "velox/exec/tests/utils/HiveConnectorTestBase.h" // @manual #include "velox/exec/tests/utils/PlanBuilder.h" #include "velox/type/tests/SubfieldFiltersBuilder.h" -#include "velox/connectors/hive/HiveConfig.h" -#include "velox/dwio/parquet/writer/Writer.h" +#include "velox/connectors/hive/HiveConfig.h" // @manual=//velox/connectors/hive:velox_hive_connector_parquet +#include "velox/dwio/parquet/writer/Writer.h" // @manual using namespace facebook::velox; using namespace facebook::velox::exec;