Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes OPTIONS type error #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lmammino
Copy link

@lmammino lmammino commented Jan 5, 2022

Should fix #4

@lmammino
Copy link
Author

lmammino commented Jan 5, 2022

I was not able to get the tests to be green (even before these changes), so I am not entirely sure that this is fully working. @bind-almir could you have a look and let me know if this makes sense? Happy to spend more time writing tests if needed, but i'd love to get the tests on master green first.

@lmammino
Copy link
Author

Hello @bind-almir, any chance you could have a look at this one?

Thanks

@camhart
Copy link

camhart commented Sep 12, 2022

@bind-almir lets get this merged in please! Not every endpoint has an options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The OPTIONS addition lead to a TypeError
2 participants