Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify rdchiral installation #6

Open
cthoyt opened this issue Aug 27, 2020 · 3 comments · May be fixed by #7
Open

Simplify rdchiral installation #6

cthoyt opened this issue Aug 27, 2020 · 3 comments · May be fixed by #7

Comments

@cthoyt
Copy link

cthoyt commented Aug 27, 2020

While installing the package, I didn't understand why there was a copy of the rdchiral codebase, which appears to be available from PyPI. Could this be added to the environment.yml instead of distributing it? Or, if you've made some changes, it would be a good thing to outline what they were.

I tested that this works if you point to the canonical codebase, so I'd be happy to send a PR with the corresponding update.
@cthoyt cthoyt linked a pull request Aug 27, 2020 that will close this issue
Open
@binghong-ml
Copy link
Owner

Thanks for the suggestion! But since we are using a modified version of the rdchiral package, we cannot replace it with the pypi version unless we've done thorough testing. We will leave that as an option for the users.

@SGenheden
Copy link

What modifications to RDChiral have you done?

@cthoyt
Copy link
Author

cthoyt commented Sep 18, 2020 •
edited
Loading

I think an alternate solution that would be helpful for both me and @SGenheden would be if you forked the original RDChiral repository (https://github.com/connorcoley/rdchiral) and made the updates there. Then you would be able to do the following:

  1. Make a comparison of changes
  2. Possibly give improvements back to the developer
  3. Have a bit more of a logical way of incorporating dependencies in your setup.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update rdchiral dependency cthoyt/retro_star
3 participants
@cthoyt @SGenheden @binghong-ml