Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recrate original object incl. data after loading model #81

Open
martinrohbeck opened this issue Jul 2, 2023 · 1 comment
Open

Recrate original object incl. data after loading model #81

martinrohbeck opened this issue Jul 2, 2023 · 1 comment
Assignees

Comments

@martinrohbeck
Copy link
Collaborator

martinrohbeck commented Jul 2, 2023

Currently we are stripping the ._data attribute of the FA model before saving. I think that makes sense, to save memory.
However, when reloading the model, we should be able to re-add data to still run downstream analysis, that user proeprties from self._data. Otherwise, we have to make sure that the important downstream functionalities work w/o self._data
This currently does not work, because add_data() throws an error. @ data expert @timtreis, maybe you can have a look at this?

Feel free to use the notebook in the current PR from branch feature/issue-x/example-notebook as an example. I already added the cell, but commented it out it.

@martinrohbeck
Copy link
Collaborator Author

Save all statistics: w, z, .... in a mudata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants