Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalizer.normalize() is performing sequence position validation which cannot be skipped #705

Open
mihaitodor opened this issue Oct 9, 2023 · 4 comments
Labels
keep alive exempt issue from staleness checks

Comments

@mihaitodor
Copy link

The code here tests whether the sequence position actually exists, but there isn't any way to skip this test which requires fetching sequence data. Would it not make sense to skip it when the validate parameter is set to False? Also, I see there's a TODO in there which I guess should also be addressed (but not sure how):

# tests whether the sequence position actually exists
# This is *way* janky.
# TODO: push functionality to hdp which can implement differently
# based on capabilities of sequence backend
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Nov 28, 2023
@mihaitodor
Copy link
Author

Bump

@github-actions github-actions bot removed the stale Issue is stale and subject to automatic closing label Nov 29, 2023
Copy link

github-actions bot commented Mar 2, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Mar 2, 2024
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@jsstevenson jsstevenson reopened this Mar 11, 2024
@jsstevenson jsstevenson added keep alive exempt issue from staleness checks and removed stale Issue is stale and subject to automatic closing closed-by-stale labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep alive exempt issue from staleness checks
Projects
None yet
Development

No branches or pull requests

2 participants