-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAREamics as a community partner #100
Comments
Let's get CAREamics onboard! Here you can find details on the technical steps of how to become a community partner (I will help you complete these steps):
|
Hi @FynnBe, thanks for getting back to this, I will make the PR adding the CAREamics info to the json file shortly. For the compatibility script, is there a way to test it is working as expected before we make a PR? I gather we just need to save a compatibility report file using the |
No, that's pretty much it. You can also use the CompatibilityReport(TypedDict) as a typed dict in your code if you have issues with the dependencies of the collection_backoffice. |
Small update: collection/scripts/script_utils.py Lines 48 to 72 in 5327dac
This simplifies the compatibility script needed from a partner, e.g. ilastik example, so now almost only an analog to collection/scripts/check_compatibility_ilastik.py Lines 16 to 25 in 5327dac
is needed to implement the compatibility check. Hope this makes things easier now and more maintainable in the future! |
CAREamics will need to check that a CAREamics config.yaml is also included and able to instantiate our pydantic classes; to save me looking through source code, what is the best way to retrieve the url for this file? Additional question: should we also check the model is loadable (i.e. has compatible architecture), or will downloading model weights be too costly/time consuming? |
I suppose your models add this You should use bioimageio.spec to download the models (e.g. by simply loading them with If you want to only deal with v0_5.ModelDescr you can simply check the |
Yep it is added in attachments field, but there is no additional info in the rdf file.
So this means, in regards to my previous question, I will have access to the model weights and so I might as well check that the model architecture is compatible? |
hmm..
yes, you should in fact. Ideally even run one training iteration (not epoch) and an inference test. CI only has CPU, but the time limit is pretty generous and we could ensure not to test everything at once if this becomes a bottleneck. |
Our config files can be ~60 lines long, we already have 3 models uploaded with a separate configuration file, I would rather not check for both cases so if we change how we export to bmz then I would like to update these existing models. In the case we do not insert the CAREamics config into the rdf.yaml file, what extra info needs to be added under config.careamics? the file name is already included in the attachments section. |
For developing the script, I would like to test locally, how can I get access to an example rdf_url? (from one of the uploaded CAREamics models). |
yeah, updating 3 models isn't a big deal 👍
short answer: nothing. |
hmm.. there are a few options. first to mind: search for the model id in https://uk1s3.embassy.ebi.ac.uk/public-datasets/bioimage.io/all_versions.json |
Hi @FynnBe, now that I have the compatibility script written, could you give me a few pointers on the CI workflow config? I've had a look at the ilastik one, but it would be good to have an overview. So I obviously need to set up the environment, installing CAREamics and dependencies, then I need to generate the reports using my check_careamics_compatibility.py script and finally the reports should be uploaded using scripts/upload_reports.py and I can copy and paste the S3 environment variables? |
I don't know exactly what you mean here, but you don't need to do anything with the S3 env variables. They are already set up in this repo, so your workflow can just use them. Essentially the careamics workflow can look pretty much exactly like the ilastik one. You can give it a go if you like, otherwise I can make a draft end of next week or so and have you fill in the details there. |
Hi @FynnBe, All I meant was I should copy how the upload-reports job is set up in the ilastik compatibility check workflow. But if you could get me started with a template that would be much appreciated ! Just to let you know we are working on a couple of things before we make a new release and update the models already in the bmz; the models are not going to pass the checks I wrote until this happens. So no rush 😄. (We are reviewing and updating the information in our generated README, and adding cover generation). |
We would like to add CAREamics as a community partner to the bioimage model zoo!
About
Resources
Maintenance
Links
CAREamics organisation: https://github.com/CAREamics
CAREamics source code: https://github.com/CAREamics/careamics
The text was updated successfully, but these errors were encountered: