-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
halo should only be allowed for output axes with a size reference #579
Comments
Not sure I get what the overlap would do here... All tiles should have the same halo to crop (or mask out for that matter). If you want to do any smoothing/blending (hence the lower than tile size stride) you have to do it yourself? Halo: possibly invalid/erroneous region, should be removed (masked out, cropped). |
I really mean "stride" here. (I added "(overlap)" as an output tensor's halo that is cropped can only be stitched without gaps if input tiles overlap. (but I'm not considering overlapping inner output blocks here)) |
Hello. I'm still not sure what's the question but from my experience with different libraries I'd expect the following without checking the documentation:
So overlap and stride are somewhat interchangeable while tile shape/stride/halo can be independent Now I looked up and this is how Constantine explained what happens in this library: ttttttttttttttttttttttttttttttttttttttttttttt tttttttttttttt So the overlap corresponds to 2 * halo, and the part of the halo that is closer to the tile is left. So currently there's no averaging of predictions. Is that what you want to change? |
Thanks @Buglakova for this overview! |
we define
halo
on output axes, denoting the border region that may suffer from artifacts.When tiling an input image and cropping the halo from the output it is essential to know how the output halo maps to the input tile stride (overlap). This is only possible if the output axis with halo has a
SizeReference
size to an input axis.cc @k-dominik @Buglakova @Josh-Talks
The text was updated successfully, but these errors were encountered: