Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge with aicspylibczi? #5

Open
toloudis opened this issue Oct 19, 2023 · 3 comments
Open

merge with aicspylibczi? #5

toloudis opened this issue Oct 19, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@toloudis
Copy link
Contributor

toloudis commented Oct 19, 2023

Feature Description

Crazy Idea: bring the aicspylibczi code into this repo so it can be maintained separately. Currently aicspylibczi is used by both aicsimageio and bioio-czi.

Use Case

Because this repo can act as a self-contained czi file reader, we don't necessarily need to have aicspylibczi as a dependency. It could all live in this single repo.

Solution

Copy all aicspylibczi code into here, set up and modernize the c++ build with python wrapper object (this is the only heavy lift). Adopt the gh-actions build and test matrix from aicspylibczi. Bring the libCZI dependency up to date.

Alternatives

The alternative is to continue to keep aicspylibczi as a separate dependency.

@toloudis toloudis added the enhancement New feature or request label Oct 19, 2023
@SeanLeRoy
Copy link
Contributor

Shelving this until we see or anticipate divergence in usage between this package's usage of aicspylibczi and aicsimageio's usage of aicspylibczi at which time we can evaluate what the best route is going forward. The motivation to wait until such time came from a discussion about the usage of aicspylibczi outside of aicsimageio and bioio-czi which would mean we would need to support those use cases somehow as well resulting in potentially little benefit to moving aicspylibczi into bioio-czi at this moment.

@SeanLeRoy
Copy link
Contributor

Consider CZI's own reader which includes remote reading instead of continuing with aicspylibczi

@cudmore
Copy link

cudmore commented Dec 19, 2023

What is CZI's own reader and where can I find it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants