Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with advanced snipinspector d3 tutorial #43

Open
paulirish opened this issue Mar 7, 2015 · 0 comments
Open

Issues with advanced snipinspector d3 tutorial #43

paulirish opened this issue Mar 7, 2015 · 0 comments

Comments

@paulirish
Copy link

I'm into javascript and my wife is a genetics phd candidate this was some fun for us on saturday afternoon. Thank you!. :)

example code fails from missing category

If you take the final code and try that out it fails on a missing data.category.

Thats because we never really hooked up chromosome_data to the rest and the final code doesn't really do it either.

var chromosome_data = [{category: "del", number: 1}, {category: "hetero": ,number: 2} , {category: "homo" , number: 3}];

Maybe you left it as a bug for people trying to skip to the end, but.. maybe give them a wink because its still incomplete. ;)

biojs-io-snipspector incorrectly parsing X chromosome

Probably a bug for @biojs-edu/biojs-io-snipspector proper, but going to report it here regardless.

My wife studies the X so when I showed her https://github.com/biojs-edu/biojs-io-snipspector/blob/82ed17739eb030f44cfb1bb727b65824178b81e1/src/index.js#L56-L68 she indicated this is tossing out most of the chromosome.

Only the PAR of the X is has diploid genes, and as you can see in the diagram, that's a very small portion of the overall gene.

image

X definitely has the best looking d3 pie chart of the chromosomes, so i imagine that's why it was picked for the tutorial, but it turns out its probably the least accurate results from the snipinspector for all chromosomes.

her quick recommendation for addressing the incorrect parser:

  • if the genotype is of length one
    • if its missing the character (so either _ or -), then its a missing genotype.
    • else it's hemizygous (and you're a male)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant