Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatter Plot: Error Bars #6934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Nov 20, 2024

Issue

Add Error Bars to points.

Closes #6428.

Description of changes
  • introduce a dialog for variable selection
  • add error bars to plot
Includes
  • Code changes
  • Tests
  • Documentation

@VesnaT VesnaT force-pushed the scatterplort_errorbars branch 2 times, most recently from 1ced1a4 to 60edc50 Compare November 20, 2024 10:47
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 97.07602% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.46%. Comparing base (c2c1648) to head (7d69fd9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6934      +/-   ##
==========================================
+ Coverage   88.45%   88.46%   +0.01%     
==========================================
  Files         331      332       +1     
  Lines       73099    73257     +158     
==========================================
+ Hits        64659    64808     +149     
- Misses       8440     8449       +9     
---- 🚨 Try these New Features:

@janezd
Copy link
Contributor

janezd commented Dec 4, 2024

I had to change glasses to see what's actually in the button.

Screenshot 2024-12-04 at 12 32 20

If any, I think it should be delta, not epsilon. But what I had in mind would be an icon like this.

Screenshot 2024-12-04 at 12 21 21

It takes a bit more space (which I'm sorry for), but it's better to take space that to look weird. :)

I'd also slightly modify the dialog, like this:

Screenshot 2024-12-04 at 12 30 50

I think it was not very clear what "Difference" and "Absolute" meant. Now it may be a bit better, though a tooltip would help.

One minor comment: "Upper" and "Lower" make more sense for y. For x, the order is also weird -- there I'd expect to set the lower limit first.

I cannot push a new commit to this PR, so I'm attaching a diff and the icons.

interval-horizontal
interval-vertical
addicons.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error bars to the scatter plot
3 participants