-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Scatter Plot: Error Bars #6934
base: master
Are you sure you want to change the base?
Conversation
1ced1a4
to
60edc50
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6934 +/- ##
==========================================
+ Coverage 88.45% 88.47% +0.02%
==========================================
Files 331 332 +1
Lines 73099 73272 +173
==========================================
+ Hits 64659 64829 +170
- Misses 8440 8443 +3 |
60edc50
to
ba412dd
Compare
ba412dd
to
7d69fd9
Compare
I had to change glasses to see what's actually in the button. If any, I think it should be delta, not epsilon. But what I had in mind would be an icon like this. It takes a bit more space (which I'm sorry for), but it's better to take space that to look weird. :) I'd also slightly modify the dialog, like this: I think it was not very clear what "Difference" and "Absolute" meant. Now it may be a bit better, though a tooltip would help. One minor comment: "Upper" and "Lower" make more sense for y. For x, the order is also weird -- there I'd expect to set the lower limit first. I cannot push a new commit to this PR, so I'm attaching a diff and the icons. |
2a74ca6
to
977eecc
Compare
977eecc
to
026e4f7
Compare
b25d35c
to
5f17fc3
Compare
5f17fc3
to
92837cf
Compare
Issue
Add Error Bars to points.
Closes #6428.
Description of changes
Includes