[ENH] OWManifold: support t-SNE on sparse #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good, but I get errors upon selecting Jaccard, Chebyshev and Mahalanobis distances. Could we:
Everything else seems to work fine. |
kernc
force-pushed
the
owmanifold-sparse
branch
3 times, most recently
from
69d7893
to
44cbd05
Compare
Codecov Report
@@ Coverage Diff @@
## master #2281 +/- ##
==========================================
+ Coverage 73.2% 73.24% +0.04%
==========================================
Files 316 316
Lines 55289 55301 +12
==========================================
+ Hits 40475 40507 +32
+ Misses 14814 14794 -20 |
|
Now errors on invalid distance. @astaric How do I accommodate radon? |
kernc
force-pushed
the
owmanifold-sparse
branch
2 times, most recently
from
540bcd4
to
187953e
Compare
nikicc
approved these changes
May 16, 2017
| self.send_signal("Data", data) | ||
| self.widget.apply_button.button.click() | ||
| self.assertTrue(self.widget.Error.sparse_not_supported.is_shown()) | ||
| self.widget.apply() |
There was a problem hiding this comment.
Why we need this apply? Doesn't the above line do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2158
Description of changes
Support sparse with method=t-SNE and tweaked params.
Includes