[FIX] gui: Suppress mouse button release on the combo box popup #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for QTBUG-67583
ales-erjavec
force-pushed
the
combo-box-popup-block-mouse-release
branch
from
826ec94 to
857ff5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3025 +/- ##
==========================================
+ Coverage 82.19% 82.43% +0.24%
==========================================
Files 335 335
Lines 57688 58593 +905
==========================================
+ Hits 47417 48302 +885
- Misses 10271 10291 +20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The QComboBox popup sometimes hides immediately after being displayed. For this to happen the model displayed in the combo box must be sufficiently large and/or slow so that the popup display is somewhat delayed (QTBUG-67583).
Description of changes
Implement a workaround for QTBUG-67583
Includes