Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix crash in Preprocess' Select Relevant Features when there are no features #4207

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Nov 21, 2019

Issue

Fixes #4202

Description of changes

When mask was empty, numpy assumed dtype is float instead of bool.

Includes
  • Code changes
  • Tests

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #4207 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4207      +/-   ##
==========================================
+ Coverage   85.95%   85.95%   +<.01%     
==========================================
  Files         393      394       +1     
  Lines       70128    70153      +25     
==========================================
+ Hits        60277    60302      +25     
  Misses       9851     9851

@lanzagar lanzagar merged commit 89aa265 into biolab:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preprocess feature selection crashes when there are no features
2 participants