[ENH] OWTranspose: data info displayed in status bar #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aturanjanin
force-pushed
the
transpose_widget
branch
from
7016a89
to
56fdfed
Compare
Codecov Report
@@ Coverage Diff @@
## master #4295 +/- ##
==========================================
+ Coverage 86.68% 86.83% +0.14%
==========================================
Files 396 396
Lines 71510 71723 +213
==========================================
+ Hits 61988 62280 +292
+ Misses 9522 9443 -79 |
aturanjanin
force-pushed
the
transpose_widget
branch
from
56fdfed
to
87195a7
Compare
VesnaT
requested changes
Jan 7, 2020
| @@ -92,6 +95,10 @@ def set_data(self, data): | |||
| if self.feature_model: | |||
| self.openContext(data) | |||
| self.unconditional_apply() | |||
| if data: | |||
There was a problem hiding this comment.
I'd rather this happens before self.apply(). The apply could take a while with a big dataset. In that case the info is wrongly set through the whole procedure.
The best place is probably right after self.data = data line.
aturanjanin
changed the title
aturanjanin
force-pushed
the
transpose_widget
branch
from
87195a7
to
34e295f
Compare
aturanjanin
changed the title
VesnaT
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Display input and output data info in status bar.
Includes