Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] concurrent: Use a workaround for QObject wrapper deletion #4635

Merged
merged 6 commits into from
Jun 26, 2020

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Apr 9, 2020

Issue

Ref: gh-4615

Description of changes

Use PyOwned from biolab/orange-widget-base#58

Requires biolab/orange-widget-base#58 is merged and released.

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the fixes/task-signal-enqueue branch 3 times, most recently from 5c3831d to c3c4265 Compare April 16, 2020 08:11
@ales-erjavec ales-erjavec force-pushed the fixes/task-signal-enqueue branch 2 times, most recently from db8154c to c9eca2e Compare April 17, 2020 09:54
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #4635 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4635      +/-   ##
==========================================
- Coverage   84.18%   84.17%   -0.01%     
==========================================
  Files         277      277              
  Lines       56463    56455       -8     
==========================================
- Hits        47531    47521      -10     
- Misses       8932     8934       +2     

@ales-erjavec ales-erjavec force-pushed the fixes/task-signal-enqueue branch 5 times, most recently from 8606c70 to 9e58a1f Compare April 22, 2020 13:10
@ales-erjavec ales-erjavec force-pushed the fixes/task-signal-enqueue branch 3 times, most recently from 6e85285 to 8611330 Compare April 28, 2020 12:10
@ales-erjavec ales-erjavec changed the title [NOMERGE][FIX] Change task's signal enqueue strategy [NOMERGE][FIX] concurrent: Use a workaround for QObject wrapper deletion Apr 28, 2020
@ales-erjavec ales-erjavec force-pushed the fixes/task-signal-enqueue branch 2 times, most recently from 91857be to ad994b6 Compare May 1, 2020 19:59
@ales-erjavec ales-erjavec force-pushed the fixes/task-signal-enqueue branch 8 times, most recently from 699b7fc to 5d796ab Compare June 12, 2020 14:51
@ales-erjavec ales-erjavec changed the title [NOMERGE][FIX] concurrent: Use a workaround for QObject wrapper deletion [FIX] concurrent: Use a workaround for QObject wrapper deletion Jun 12, 2020
@ales-erjavec ales-erjavec force-pushed the fixes/task-signal-enqueue branch from 5d796ab to 8639bba Compare June 17, 2020 07:57
@janezd janezd self-assigned this Jun 26, 2020
@janezd janezd merged commit 31c0b27 into biolab:master Jun 26, 2020
@ales-erjavec ales-erjavec deleted the fixes/task-signal-enqueue branch August 5, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants