Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix slicing in from_table #4963

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

markotoplak
Copy link
Member

@markotoplak markotoplak commented Sep 1, 2020

Issue

For reverse slices row_indices in Table.from_table did not work properly. Also, that part of from_table was not properly tested, probably because of some optimizations that were added later.

Description of changes

Handcrafted (but wrong) measuring of slice length was replaced with calling standard methods.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #4963 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4963      +/-   ##
==========================================
- Coverage   84.29%   84.29%   -0.01%     
==========================================
  Files         283      283              
  Lines       58016    58013       -3     
==========================================
- Hits        48904    48900       -4     
- Misses       9112     9113       +1     

Slicing in from_table was not properly tested, because the same domain
was used and therefore the calls for forwarded to from_table_rows.
Handcraft (but wrong) measuring of slice length was replaced with
calling standard methods.
@markotoplak markotoplak force-pushed the fix-from-table-slicing branch from 7064b75 to 9bcc22a Compare September 2, 2020 10:50
@janezd janezd self-assigned this Sep 3, 2020
@janezd janezd closed this Sep 4, 2020
@janezd janezd reopened this Sep 4, 2020
@janezd janezd merged commit 14d74d0 into biolab:master Sep 4, 2020
@markotoplak markotoplak deleted the fix-from-table-slicing branch September 28, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants