Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] table_to_frame - handle numeric columns with dtype=object #5474

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

PrimozGodec
Copy link
Contributor

Issue

table_to_frame fails when array (usually metas) have dtype=object and column holds numeric values. Look newly-added test.

Description of changes

Use pd.isnull instead of np.isnan which correctly handle columns with dtype=object.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the table_to_frame-fix branch from c8f7cc2 to 3758d85 Compare June 7, 2021 19:25
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #5474 (3758d85) into master (a78eaf3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5474   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files         304      304           
  Lines       61652    61652           
=======================================
  Hits        53240    53240           
  Misses       8412     8412           

@VesnaT VesnaT merged commit f43d167 into biolab:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants